kpdev42 added a comment. In D140368#4007234 <https://reviews.llvm.org/D140368#4007234>, @DavidSpickett wrote:
> The intent makes sense. We should stop and report user breakpoints triggered > while trying to execute some internal stepping plan, even if they overlap > what lldb was planning to do in the first place. > > Not totally sure how the change achieves that, this is quite the function. + > @jingham who wrote the original changes. > >> Currently in some cases lldb reports stop reason as "step out" or "step >> over" (from thread plan completion) over "breakpoint" > > This would be clearer if you said "(from thread plan completion) instead of > "breakpoint"". Took me a while to work out that it wasn't over meaning step > over a breakpoint. > > I think the test naming could be clearer. > `breakpoint/step_out_breakpoint/TestStepOutBreakpoint.py` implies it's just > about stepping out. How about > `breakpoint/thread_plan_user_breakpoint/TestThreadPlanUserBreakpoint.py` ? > Something that is clear we're testing the interaction of automatic internal > stepping plans and breakpoints the user puts in. > > Is it worth checking that an unconditional user breakpoint is also reported? Fixed, please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https://reviews.llvm.org/D140368 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
