labath added a comment.
Yeah, I'm afraid this is all my fault. I suggested going in this direction, but
this isn't exactly how I thought it would turn out. I was expecting that the
inferface would be something along the lines of what Jonas posted in his
comment. And I was not expecting that you will try to convert every single
instance of PRIx32 dwarf offset printing. The majority of the modified lines
are the ReportError and ReportWarning statements, so I though we would just be
converting those. And the majority of the callers of these functions are coming
from DWARF code, so I agree with Jonas that it would be nice to convert all
callers of these functions -- but I won't insist on it.
I guess I should have been more explicit about my expectations -- I'm sorry.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:512
+ dwarf->GetObjectFile()->GetModule()->ReportError(std::string(
+ llvm::formatv("{{{0:x+16}}}}: unhandled type tag {1:x+4} ({2}), "
+ "please file a bug and "
----------------
You could just change this to print a different delimiting character (`[` for
instance).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139955/new/
https://reviews.llvm.org/D139955
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
