int3 added a comment.
lld/MachO changes lgtm
================
Comment at: lld/MachO/Driver.cpp:1386
// ld64 does something really weird. It attempts to realign the value to
the
- // page size, but assumes the the page size is 4K. This doesn't work with
+ // page size, but assumes the page size is 4K. This doesn't work with
// most of Apple's ARM64 devices, which use a page size of 16K. This means
----------------
"assumes that the page size" sounds more natural and is probably what was
intended
================
Comment at: lld/MachO/UnwindInfoSection.cpp:576-577
// entries by using the regular format. This can happen when there
- // are many unique encodings, and we we saturated the local
+ // are many unique encodings, and we saturated the local
// encoding table early.
if (i < cuIndices.size() &&
----------------
I think we can reflow this paragraph to max the line length
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137338/new/
https://reviews.llvm.org/D137338
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
