lh03061238 added a comment.
================ Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:66 + uint32_t reg_num) override; + lldb::addr_t ReadPC(bool *success); + bool WritePC(lldb::addr_t pc); ---------------- SixWeining wrote: > Could it be a private function? > Could it be a private function? We want this function to be used in its subclass, so we define it as public ================ Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:79 + + bool EmulateNonJMP(uint32_t inst); +}; ---------------- SixWeining wrote: > Is it a override function? > Is it a override function? It is not override function, this function simply returns false. SetupSoftwareSingleStepping () function will be updated PC (next_pc = PC + 4), when EvaluateInstruction exit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139158/new/ https://reviews.llvm.org/D139158 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
