tmatheson added a comment.
Herald added a subscriber: JDevlieghere.

> And this is the file that was being generated: 
> https://github.com/ziglang/zig/blob/c86589a738e5053a26b2be7d156bcfee1565f00b/lib/std/target/aarch64.zig

Thanks for the heads up. It looks like that file hasn't been updated for a 
couple of years, and doesn't include any recent features, so unless we hear 
otherwise from @andrewrk I think we can go ahead. If some script _is_ manually 
parsing the .def, it ought to be easy enough to update it to read the .cpp 
instead (it probably shouldn't do either).

> Please update the comment in 
> lldb/test/Shell/Commands/command-disassemble-aarch64-extensions.s as well.

I have reordered the list to be alphabetical and updated the comment, added 
tests for recent features that were missed (CSSC, D128 
<https://reviews.llvm.org/D128>, RCPC3, THE, and a few others) and used 
CHECK-NEXT.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139102/new/

https://reviews.llvm.org/D139102

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to