aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
LGTM with a slightly more relaxed test
================
Comment at: lldb/source/Target/Target.cpp:1707
+
+ if (should_flush_type_systems) {
+ m_scratch_type_system_map.Clear();
----------------
nit: no {} in LLVM style
================
Comment at: lldb/test/API/functionalities/rerun_and_expr/TestRerunAndExpr.py:47
+
+ self.filecheck("target module dump ast", __file__)
+
----------------
This is really great — I didn't know we already had this!
================
Comment at: lldb/test/API/functionalities/rerun_and_expr/TestRerunAndExpr.py:51
+ # CHECK: |-CXXRecordDecl {{.*}} struct Foo definition
+ # CHECK-NEXT: | |-DefinitionData pass_in_registers standard_layout
trivially_copyable trivial literal
+ # CHECK-NEXT: | | |-DefaultConstructor exists trivial needs_implicit
----------------
This may be checking too much detail. I don't know how frequently the Clang AST
changes, but if there is any information we don't really need I would try to
omit it so we don't have to update this test every couple of months.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138724/new/
https://reviews.llvm.org/D138724
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
