labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:65
+ Target *target_ptr = exe_ctx.GetTargetPtr();
+ Target &target = target_ptr ? *target_ptr : GetDummyTarget();
+
----------------
I don't think this will work with a dummy target if you specify
`eCommandRequiresProcess`.
================
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:71
+ if (verbosity != eDWIMPrintVerbosityNone)
+ result.AppendMessageWithFormatv("note: ran `expression {0}`", expr);
+ valobj_sp->Dump(result.GetOutputStream());
----------------
If the expectation is that the users should be able to paste this command, then
we'd better add a `--` here. Otherwise expressions like `-foo` will not work as
they will be confused for options.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138315/new/
https://reviews.llvm.org/D138315
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
