mib marked 3 inline comments as done.
mib added inline comments.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:191-194
+template <> struct PythonFormat<char *> {
+ static constexpr char format = 's';
+ static auto get(char *value) { return value; }
+};
----------------
labath wrote:
> Maybe something like:
> ```
> template<typename T, char F> struct PassthroughFormat {
> static constexpr char format = F;
> static constexpr T get(T t) { return t; }
> };
>
> template<> struct PythonFormat<char *> : PassthroughFormat<char *, 's'>;
> // etc.
> ```
More templates <3 !
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138248/new/
https://reviews.llvm.org/D138248
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
