DavidSpickett added a comment.

What was the decision on `m_dwarf_cu` possibly being nullptr? We at least want 
asserts in paths where we assume it'll not be null.

Beyond that this seems fine but I'm not really into DWARF, @labath any comments?

Seems like quite a cheap fallback to add, and my assumption is that we don't 
find many unknown opcodes in general use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137247/new/

https://reviews.llvm.org/D137247

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to