DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land.
LGTM. Do what makes sense to you with the comment. ================ Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:146 + # reason is used for both args. + return unittest2.skipIf(reason, reason)(func) ---------------- This would make more immediate sense if you added the function prototype as well: ``` # skipIf(condition, reason) ``` Or if you can figure a way to do the C++ style `skipIf(/*condition=*/reason, reason)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138181/new/ https://reviews.llvm.org/D138181 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
