labath added a comment. Looks good, but I think you missed one comment.
================ Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h:90 void Dump(Stream &stream); + static void RequireCompleteType(CompilerType type); ---------------- labath wrote: > I forgot about this the first time around, but it'd be nice if this code > could be shared between the pdb and dwarf plugins. Maybe by putting it into > TypeSystemClang ? Did you perhaps miss this comment/request? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/new/ https://reviews.llvm.org/D134066 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
