labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D137098#3903547 <https://reviews.llvm.org/D137098#3903547>, @aeubanks wrote:

> In D137098#3902140 <https://reviews.llvm.org/D137098#3902140>, @labath wrote:
>
>> Why is it that the other indexes don't need an equivalent fix? Could it be 
>> that you just haven't tried those code paths?
>>
>> If they do need it, then it'd be good if we could make the fix in a single 
>> place. Possibly by putting the retry logic at a higher level?
>
> Other indexes as in the other manual index indexes? Or as in other higher 
> level indexes?

I meant the compiler-generated indexes (implementations in AppleDWARFIndex and 
DebugNamesDWARFIndex).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137098/new/

https://reviews.llvm.org/D137098

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] [PATCH] D13... Pavel Labath via Phabricator via lldb-commits

Reply via email to