jj10306 added inline comments.
================
Comment at: lldb/source/Plugins/Trace/intel-pt/LibiptDecoder.cpp:299-307
+ uint64_t offset;
+ int status = pt_insn_get_offset(m_decoder_up.get(), &offset);
+ if (!IsLibiptError(status)) {
+ err_msg =
+ formatv("At byte offset {0} of PSB with size {1} bytes, {2}",
+ offset, m_psb_block.size, err_msg)
+ .str();
----------------
wallace wrote:
> I think let's better not include this to keep the error a bit smaller. In any
> case, you can do `thread trace dump instructions <thread> -E` and then look
> for the error prefix when debugging.
>
> but if you insist, the byte offset message should come after the textual
> description of the error
I included the byte offset information so we can get an idea of what % of data
we are losing each time this occurs. I'll clean this up a bit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136610/new/
https://reviews.llvm.org/D136610
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
