DavidSpickett added a comment.

> Technically yes, but then we have two ad-hoc solutions that support half the 
> log handlers. I think if we care about that we might as well go with the 
> T-based log handler behind the scenes.

Sure. More wondering whether the choice between circular buffer and file is a 
whole lot of code, but it isn't if we already have buffers.

Saving log files only sounds good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135631/new/

https://reviews.llvm.org/D135631

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to