clayborg added inline comments.
================
Comment at: lldb/source/Commands/CommandObjectDiagnostics.cpp:84
+ if (!directory) {
+ result.AppendError(llvm::toString(directory.takeError()));
+ result.SetStatus(eReturnStatusFailed);
----------------
Do we want to just create a temp directory if the user didn't specify one here
and them emit the path to where things were saved instead of erroring out?
================
Comment at: lldb/source/Utility/Diagnostics.cpp:58
bool Diagnostics::Dump(raw_ostream &stream) {
+ Expected<FileSpec> diagnostics_dir = CreateUniqueDirectory();
----------------
How are we dumping these to the directory the user specifies the directory in
"diagnostic dump"? Below we create a unique directory. Seems like this API
should take a "Optional<FileSpec> directory" parameter and if it doesn't have a
value, then create a unique directory?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135622/new/
https://reviews.llvm.org/D135622
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
