DavidSpickett added inline comments.
================ Comment at: lldb/source/Utility/Diagnostics.cpp:43 + std::lock_guard<std::mutex> guard(m_callbacks_mutex); + m_callbacks.push_back(callback); +} ---------------- DavidSpickett wrote: > Is it worth adding an assert that the callback is not already in the list? > > (and below, that the callback is in fact in the list) Is this still relevant? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134991/new/ https://reviews.llvm.org/D134991 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
