mib marked 2 inline comments as done.
mib added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:581-597
+ def parse_asi_backtrace(self, thread, bt):
+ for line in bt.split('\n'):
+ frame_match = TextCrashLogParser.frame_regex.search(line)
+ if not frame_match:
+ print("error: can't parse application specific backtrace.")
+ return False
+
----------------
JDevlieghere wrote:
> Can this be a top level function? It's hard to tell if this is capturing
> anything. We have other place where we have helper functions that are called
> from a loop.
This parses a single backtrace. I'm not sure what you mean by "We have other
place where we have helper functions that are called from a loop."
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1000
+ StructuredData::Array *arr = val->GetAsArray();
+ if (!arr || !arr->GetSize())
+ return false;
----------------
JDevlieghere wrote:
> Should this check if the size == 1?
I don't think this should only work if the dictionary has only 1 item.
================
Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:491
+
+ Status error;
+
----------------
JDevlieghere wrote:
> Is this ever populated?
It is used below in `ErrorWithMessage`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126260/new/
https://reviews.llvm.org/D126260
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
