labath added a comment.
I don't know how coff symbol tables work, but this seems reasonable to me.
================
Comment at: lldb/test/Shell/ObjectFile/PECOFF/symbols-export-table.yaml:10
+# CHECK-NEXT: D Code 0x0000000180001010 0x{{[0-9a-f]+}}
0x{{[0-9a-f]+}} exportfunc
+# CHECK-NEXT: Code 0x0000000180001000 0x{{[0-9a-f]+}}
0x{{[0-9a-f]+}} entry
+# CHECK-NEXT: Code 0x0000000180001010 0x{{[0-9a-f]+}}
0x{{[0-9a-f]+}} exportfunc
----------------
Even though it does not look like that, this will match an entry with any flags
(because FileCheck does a substring match). The simplest solution would be to
match the preceding UserID field as well.
================
Comment at: lldb/test/Shell/ObjectFile/PECOFF/symbols-export-table.yaml:34-75
+ ImportTable:
+ RelativeVirtualAddress: 0
+ Size: 0
+ ResourceTable:
+ RelativeVirtualAddress: 0
+ Size: 0
+ ExceptionTable:
----------------
Could this be reduced? Maybe by removing these zero fields?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134196/new/
https://reviews.llvm.org/D134196
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
