alvinhochun added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:819
+ if (exported->GetType() != lldb::eSymbolTypeReExported &&
+ exported->GetAddressRef() == symbols[i].GetAddressRef()) {
+ symbols[i].SetID(exported->GetID());
----------------
mstorsjo wrote:
> alvinhochun wrote:
> > mstorsjo wrote:
> > > What about the case when a symbol is exported with a different name than
> > > the local symbol? (This is doable with def files e.g. as `ExportedName =
> > > LocalName` iirc.) Is it worth to have a map of address -> exported
> > > symbol, to use instead of the raw name?
> > Indeed it is a good idea to match symbols with different export names to
> > synchronize the symbol types. I probably should use a `vector<pair<address,
> > export_name>>` sorted by address for lookup instead.
> Is it even relevant to keep the name in the vector in that case? As you'd
> only be looking up on address anyway, and based on that you can get the
> symbol name from the pointed-at symbol anyway, right?
Ah, I guess I meant to say the symbol index there...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134133/new/
https://reviews.llvm.org/D134133
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
