[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47
     lldbUtility
+    lldbPluginDynamicLoaderDarwinKernel
+    lldbPluginObjectContainerMachOFileset
----------------
thakis wrote:
> This causes a dependency cycle:
> 
>   //lldb/source/Plugins/Platform/MacOSX:MacOSX ->
>   //lldb/source/Plugins/DynamicLoader/Darwin-Kernel:Darwin-Kernel ->
>   //lldb/source/Plugins/Platform/MacOSX:MacOSX
Ach, naturally.  DynamicLoaderDarwinKernel has to create a PlatformDarwinKernel 
to set in the Target when it is initializing itself.  :/  Maybe I'll just add 
DynamicLoaderDarwinKernel to the unit tests that have PlatformMacOSX in them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133534/new/

https://reviews.llvm.org/D133534

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits