mgorny accepted this revision. mgorny added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteLaunch.py:18 + args = [exe_path, "stderr:arg1", "stderr:arg2", "stderr:arg3"] + hex_args = [seven.hexlify(x) for x in args] + ---------------- labath wrote: > mgorny wrote: > > Since we no longer support Python 2, I'd rather prefer to work towards > > removing `seven` rather than making more use of it. > Is the problem with the name/location of the function or the functionality > (string/byte conversion) itself? > Because, if it's the first, then that could easily be solved by renaming the > module (now or later), but in order to avoid elaborate casts we'd have to > make all code be byte/string correct. This is not a problem here (because of > the fixed strings), but it becomes one once you start working with things > that aren't necessarily valid utf8 strings. Ok, I suppose this makes sense given how LLDB's Python API is screwed up :-(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133352/new/ https://reviews.llvm.org/D133352 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
