jasonmolenda accepted this revision. jasonmolenda added a comment. In D132433#3747948 <https://reviews.llvm.org/D132433#3747948>, @jasonmolenda wrote:
> `Process::ReadModuleFromMemory()` takes a FileSpec and header address in > memory (and a size to read, default 512 bytes). It calls through > `Module::GetMemoryObjectFile`. That reads the 512 bytes of memory into a > buffer and calls `ObjectFile::FindPlugin` class method for finding the > correct plugin (via PluginManager's ObjectFileCreateMemoryInstance methods), > finally hitting something like `ObjectFileMachO::CreateMemoryInstance`. Reviewed this a little too close to bed time ;) - Jonas asked me if I really needed this up at the generic Process level, and I remembered that the one use case I am writing currently for this will be down in Darwin-specific code, so I can create the memory instance of the macho fileset explicitly. This patch looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132433/new/ https://reviews.llvm.org/D132433 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
