mgorny marked an inline comment as done.
mgorny added a comment.

Ok, so I'm going to give it a shot today. Could you clarify one thing though?

> All it would take is to add some locking around the PendingCallback 
> manipulations

Are you thinking of locking directly in `MainLoop` classes, or in the caller? 
It'd feel a bit inconsistent if `MainLoop`s provided locking around pending 
callback manipulations and not other methods. However, I suppose making 
everything thread-safe wouldn't hurt either.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131160/new/

https://reviews.llvm.org/D131160

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to