mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land.
Unfortunately, this change doesn't work correctly when building LLDB through `LLVM_ENABLE_PROJECTS` — unittests are always disabled now. ================ Comment at: lldb/CMakeLists.txt:128 +set(LLDB_INCLUDE_UNITTESTS ON) +if (NOT TARGET llvm_gtest) + set(LLDB_INCLUDE_UNITTESTS OFF) ---------------- If LLDB is built through `LLVM_ENABLE_PROJECTS`, then LLDB's CMakeLists are included before the subdirectory containing `llvm_gtest`, effectively making this condition always false. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124314/new/ https://reviews.llvm.org/D124314 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
