[Lldb-commits] [PATCH] D130937: [LLDB][NFC][Correctness] Fix bad null check

[Slava Gurevich via Phabricator via lldb-commits]

fixathon created this revision.
fixathon added reviewers: clayborg, aadsm, jingham, JDevlieghere.
Herald added a subscriber: emaste.
Herald added a project: All.
fixathon requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Fix incorrect null-check logic, likely cause by copy-paste


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D130937

Files:
  lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp


Index: lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
===================================================================
--- lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
+++ lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
@@ -161,7 +161,7 @@
                       GetAddressByteSize(), bytes_read);
   if (!status.Success())
     return status.ToError();
-  if (address == 0)
+  if (link_map == 0)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "Invalid link_map address");
 



Index: lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
===================================================================
--- lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
+++ lldb/source/Plugins/Process/POSIX/NativeProcessELF.cpp
@@ -161,7 +161,7 @@
                       GetAddressByteSize(), bytes_read);
   if (!status.Success())
     return status.ToError();
-  if (address == 0)
+  if (link_map == 0)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "Invalid link_map address");
 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits