labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1058-1060
// Terminate the main loop only if vKill has not been used.
// When running in non-stop mode, wait for the vStopped to clear
// the notification queue.
----------------
Btw, is this actually correct. E.g. I don't think we ought to terminate the
connection if a process dies "naturally", and there are still other processes
around...
Isn't it more like the opposite, that if `k` is used, *then* we close the
connection (after all processes exit)? And maybe also when the process exits,
and multiprocess extensions are disabled?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129652/new/
https://reviews.llvm.org/D129652
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
