Michael137 added inline comments.
================ Comment at: lldb/source/Expression/Materializer.cpp:432 + m_size = g_default_var_byte_size; + m_alignment = g_default_var_alignment; } ---------------- aprantl wrote: > FWIW, the refactoring of EntityVariable could have been a separate > preparatory NFC patch, then the patch that adds the lambda functionality > would be shorter. It's fine either way, but it's usually easier to review two > simple comments instead of one complex one :-) True I added it as a separate commit to this revision. Wasn't sure whether a separate patch was preferred over a separate commit in the same Phabricator revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129078/new/ https://reviews.llvm.org/D129078 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
