labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Looks good, thanks. I'd consider strengthening the test to look for overlapping address ranges instead of just identical base addresses. ================ Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:99 + + process = self.dbg.GetTargetAtIndex(0).GetProcess() + regions = process.GetMemoryRegions() ---------------- use self.process() instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129272/new/ https://reviews.llvm.org/D129272 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
