[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

[Michael Buch via Phabricator via lldb-commits]

Michael137 added inline comments.


================
Comment at: 
lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp:249
   //
   // For Lvalues
   //
----------------
Minor: Should we update this documentation?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2689
+      // TODO: Support float/double static members as well.
+      if (!attrs.const_value_form && !ct.IsIntegerOrEnumerationType(unused))
+        return;
----------------
Should this be:

```
if (!attrs.const_value_form || !ct.IsIntegerOrEnumerationType(unused))
```
?


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2696
+                       "Failed to add const value to variable {1}: {0}",
+                       v->getQualifiedNameAsString());
+        return;
----------------
Can `v` be `nullptr` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81471/new/

https://reviews.llvm.org/D81471

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits