JDevlieghere marked 4 inline comments as done.
JDevlieghere added a comment.

Thanks for pointing that out. I blindly copied the categories logic from 
`Log::Disable` which uses it when computing the flags. I've omitted it for now 
because I think it would be weird to set the circular buffer size to 5 and then 
have 0 messages printed for the process category because 5 log messages from 
the commands category pushed them out. One solution would be to keep a circular 
buffer per category. I'll think about it and if I come up with a good solution 
I'll put up another patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128557/new/

https://reviews.llvm.org/D128557

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to