labath added a comment.

This isn't turning out as clean as I had hoped it would, but I think it's a 
step in the right direction. Jonas, do you want to say anything about this?



================
Comment at: lldb/include/lldb/Expression/DWARFExpressionList.h:54
+  const DWARFExpression *
+  GetExpressionAtAddress(lldb::addr_t file_addr = 0) const;
+
----------------
calling GetExpressionAtAddress without an address seems weird. Maybe just have 
a separate GetAlwaysValidExpr getter or something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125509/new/

https://reviews.llvm.org/D125509

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to