labath added a comment.
How hot is this code? Parsing a demangled name isn't entirely cheap, and the
fact that the objc++ class calls back into the c++ version means that the c++
name will be parsed twice.
Could we move this pruning elsewhere? These values come from the symbol file
plugins anyway, and they can do a better job at determining which language does
a particular name belong to.
(OK, they can an also come from the symtab, but there I guess we could infer
something from the mangling scheme).
================
Comment at: lldb/include/lldb/Target/Language.h:320
+ virtual bool NamesAreEquivalentWithContext(
+ const ConstString &user_provided_name,
+ const ConstString &full_name_with_context) const {
----------------
I think we're passing ConstStrings by value these days...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128366/new/
https://reviews.llvm.org/D128366
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
