jj10306 added inline comments.
================ Comment at: lldb/include/lldb/API/SBDebugger.h:403 + /// trace session. + SBTrace LoadTraceFromFile(SBError &error, const char *trace_file_path); + ---------------- wallace wrote: > wallace wrote: > > JDevlieghere wrote: > > > Can this take a filespec? > > +1 > We need to come up with a good public name for the json file. I've been using > trace session file, but I dislike. What about trace description file? Then we > can have a "trace bundle" that contains "trace description file". Do you > have better suggestions? I think trace description file is a more appropriate name as well. ================ Comment at: lldb/packages/Python/lldbsuite/test/tools/intelpt/intelpt_testcase.py:139 + if self.USE_SB_API: + traceDescriptionFile = lldb.SBFileSpec(traceDescriptionFilePath) + loadTraceError = lldb.SBError() ---------------- the single arg constructor is deprecated, update this to pass `resolve` flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128107/new/ https://reviews.llvm.org/D128107 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
