jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Utility/TraceIntelPTGDBRemotePackets.cpp:25 +json::Value toJSON(const JSONUINT64 &uint64, bool hex) { + if (hex) ---------------- should there be an option to write it as an integer or would the user just be expected to use a raw u64 in that case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127819/new/ https://reviews.llvm.org/D127819 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits