wallace added inline comments.
================
Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:22
+// List of data kinds used by jLLDBGetState and jLLDBGetBinaryData.
+struct IntelPTDataKinds {
+ static const char *kProcFsCpuInfo;
----------------
jj10306 wrote:
> why not use an enum here?
> having "kinds" in the name already makes it sound like an enum and seeing
> IntelPTDataKinds:: everywhere immediately made me thing it was an enum.
this is actually an enum, but it's an enum of strings. So we have a few options:
- have a normal int enum and have another function that converts int -> const
char*.
- create a fake enum with class static variables like here
- use header inline variables, but they are not available in the C++ version
used by LLDB.
Overall I found this to be the simplest way to implement it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124573/new/
https://reviews.llvm.org/D124573
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
