shafik added a comment. In D123340#3438391 <https://reviews.llvm.org/D123340#3438391>, @labath wrote:
> The reason for the funny `/*override*/` thingy in the mock classes is that it > is impossible (in the gmock version that we use) to add the override keyword > to the methods overridden by the MOCK macros. Then, having override keywords > on hand-written methods triggered `-Winconsistent-missing-override`. > > Or at least it used to -- have you checked that these changes don't introduce > any new compiler warnings? I missed that, it does indeed trigger the same warning, I guess I will add a `NOLINT` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123340/new/ https://reviews.llvm.org/D123340 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
