labath added a comment.

> Note that this patch could have been shorter if I simply changed 
> LoadModuleAtAddress() to always pass false for notify (all callers currently 
> call ModulesDidLoad() afterwards) and added a note to LoadModuleAtAddress() 
> docs about it, but I don't know if that's a good design choice.

That would definitely be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123128/new/

https://reviews.llvm.org/D123128

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to