[Lldb-commits] [PATCH] D122998: use just '#' instead of 'frame #2' in the threads/frame view

[Luboš Luňák via Phabricator via lldb-commits]

llunak created this revision.
llunak added a reviewer: clayborg.
llunak added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
llunak requested review of this revision.
Herald added a subscriber: lldb-commits.

Since the threads/frame view is taking only a small part on the right side of 
the screen, only a part of the function name of each frame is visible. It seems 
rather wasteful to spell out 'frame' there when it's obvious that it is a 
frame, it's better to use the space for more of the function name.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D122998

Files:
  lldb/source/Core/IOHandlerCursesGUI.cpp
  lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py


Index: 
lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py
===================================================================
--- lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py
+++ lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py
@@ -33,7 +33,7 @@
         self.child.expect_exact("Threads")
 
         # The thread running thread_start_routine should be expanded.
-        self.child.expect_exact("frame #0: break_here")
+        self.child.expect_exact("#0: break_here")
 
         # Exit GUI.
         self.child.send(escape_key)
@@ -47,7 +47,7 @@
         self.child.expect_exact("Threads")
 
         # The main thread should be expanded.
-        self.child.expect("frame #\d+: main")
+        self.child.expect("#\d+: main")
 
         # Quit the GUI
         self.child.send(escape_key)
Index: lldb/source/Core/IOHandlerCursesGUI.cpp
===================================================================
--- lldb/source/Core/IOHandlerCursesGUI.cpp
+++ lldb/source/Core/IOHandlerCursesGUI.cpp
@@ -5015,8 +5015,7 @@
 public:
   FrameTreeDelegate() : TreeDelegate() {
     FormatEntity::Parse(
-        "frame #${frame.index}: {${function.name}${function.pc-offset}}}",
-        m_format);
+        "#${frame.index}: {${function.name}${function.pc-offset}}}", m_format);
   }
 
   ~FrameTreeDelegate() override = default;



Index: lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py
===================================================================
--- lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py
+++ lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py
@@ -33,7 +33,7 @@
         self.child.expect_exact("Threads")
 
         # The thread running thread_start_routine should be expanded.
-        self.child.expect_exact("frame #0: break_here")
+        self.child.expect_exact("#0: break_here")
 
         # Exit GUI.
         self.child.send(escape_key)
@@ -47,7 +47,7 @@
         self.child.expect_exact("Threads")
 
         # The main thread should be expanded.
-        self.child.expect("frame #\d+: main")
+        self.child.expect("#\d+: main")
 
         # Quit the GUI
         self.child.send(escape_key)
Index: lldb/source/Core/IOHandlerCursesGUI.cpp
===================================================================
--- lldb/source/Core/IOHandlerCursesGUI.cpp
+++ lldb/source/Core/IOHandlerCursesGUI.cpp
@@ -5015,8 +5015,7 @@
 public:
   FrameTreeDelegate() : TreeDelegate() {
     FormatEntity::Parse(
-        "frame #${frame.index}: {${function.name}${function.pc-offset}}}",
-        m_format);
+        "#${frame.index}: {${function.name}${function.pc-offset}}}", m_format);
   }
 
   ~FrameTreeDelegate() override = default;

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits