wallace added inline comments.
================ Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:172 std::vector<IntelPTInstruction> m_instructions; + std::vector<llvm::Error> m_errors; + ---------------- you need to have something like std::unordered_map<uint64_t, llvm::Error> m_errors; that way, you'll be able to quickly look for the error associated with an instruction index. The IntelPTInstruction int his case, instead of storing the Error, can just store one bit of information has_error = true/false; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
