wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed.
================ Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:123-130 + size_t non_err_instruction_count = 0; + for (const IntelPTInstruction &insn : m_instructions) + if (!insn.IsError()) + non_err_instruction_count++; + + return m_raw_trace_size + + IntelPTInstruction::GetNonErrorMemoryUsage() * non_err_instruction_count ---------------- as discussed offline, this should just be Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122093/new/ https://reviews.llvm.org/D122093 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
