aprantl added inline comments.

================
Comment at: lldb/source/Expression/DWARFExpression.cpp:971
+          "need module to resolve file address for %s", dw_op_type);
+    return {};
+  }
----------------
clayborg wrote:
> Do we prefer "return {}" over "return llvm::None"?
Personally, I do, but there's no rule about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121408/new/

https://reviews.llvm.org/D121408

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to