[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only waits for the process to stop when using "launchCommands" or "attachCommands"...

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.
Herald added a project: All.

I'm not exactly exactly thrilled by the sleep-based implementation, but 
otherwise, the patch seems fine.



================
Comment at: lldb/tools/lldb-vscode/VSCode.cpp:551
+  auto timeout_time =
+      std::chrono::high_resolution_clock::now() + 
std::chrono::seconds(seconds);
+  while (std::chrono::high_resolution_clock::now() < timeout_time) {
----------------
`steady_clock` would be better here (no time travel there)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120755/new/

https://reviews.llvm.org/D120755

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits