labath added a comment.
Herald added a project: All.
I'm not exactly exactly thrilled by the sleep-based implementation, but
otherwise, the patch seems fine.
================
Comment at: lldb/tools/lldb-vscode/VSCode.cpp:551
+ auto timeout_time =
+ std::chrono::high_resolution_clock::now() +
std::chrono::seconds(seconds);
+ while (std::chrono::high_resolution_clock::now() < timeout_time) {
----------------
`steady_clock` would be better here (no time travel there)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120755/new/
https://reviews.llvm.org/D120755
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
