aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647
+ const bool UsePointerValue) {
+ assert(CGM.getCodeGenOpts().hasReducedDebugInfo());
+ assert(!LexicalBlockStack.empty() && "Region stack mismatch, stack empty!");
----------------
shafik wrote:
> aprantl wrote:
> > do you need a
> > ```
> > if (DebugKind > codegenoptions::LimitedDebugInfo)
> > return
> > ```
> >
> > here?
> That kind of check is only used in limited places, why would it apply here as
> let's say opposed to the `EmitDeclare` for `VarDecl` case?
I think the answer is that Ty would be null then.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119178/new/
https://reviews.llvm.org/D119178
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
