labath added a comment.
This seems fine, though it's not clear to me what is the effect of this patch
in terms of functionality. Does the "side-effect" mentioned by Jim still apply
here, or is this NFC now? Either is probably fine, but I'd like to understand
what is going on. It seems like it should be NFC, but does that mean that the
demangling (and the cpu/memory cost) is delayed until the first operation which
requests it (such as matching a breakpoint by the full demangled name) ?
================
Comment at: lldb/source/Core/Mangled.cpp:198
// makes use of ItaniumPartialDemangler's rich demangle info
bool Mangled::DemangleWithRichManglingInfo(
RichManglingContext &context, SkipMangledNameFn *skip_mangled_name) {
----------------
I guess it would be more correct to call this `GetRichManglingInfo` now
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118814/new/
https://reviews.llvm.org/D118814
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
