Re: [Lldb-commits] [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

[Stella Stamenova via lldb-commits]

I will take care of it today. The bot does have vs2019 installed and it should 
be picking up latest VS (and it was when I updated it), so there is an easy fix 
(remove 2017) and then I can investigate why it stopped picking up latest.

Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Simon Pilgrim via Phabricator <revi...@reviews.llvm.org>
Sent: Saturday, January 29, 2022 3:12:52 AM
To: llvm-...@redking.me.uk <llvm-...@redking.me.uk>; Reid Kleckner 
<r...@google.com>; aaron.ball...@gmail.com <aaron.ball...@gmail.com>; 
ztur...@roblox.com <ztur...@roblox.com>; jh7...@my.bristol.ac.uk 
<jh7...@my.bristol.ac.uk>; l...@meinersbur.de <l...@meinersbur.de>; 
jan_svob...@apple.com <jan_svob...@apple.com>; greg_bedw...@sn.scee.net 
<greg_bedw...@sn.scee.net>; Stella Stamenova <sti...@microsoft.com>
Cc: jo...@devlieghere.com <jo...@devlieghere.com>; lldb-commits@lists.llvm.org 
<lldb-commits@lists.llvm.org>; h.vetin...@gmx.com <h.vetin...@gmx.com>; 
vitalyb...@google.com <vitalyb...@google.com>; jrhen...@gmail.com 
<jrhen...@gmail.com>; reviews.llvm....@jfbastien.com 
<reviews.llvm....@jfbastien.com>; erich.ke...@intel.com 
<erich.ke...@intel.com>; joker....@gmail.com <joker....@gmail.com>; Saleem 
Abdulrasool <compn...@compnerd.org>; russell.gal...@sony.com 
<russell.gal...@sony.com>; cfe-comm...@lists.llvm.org 
<cfe-comm...@lists.llvm.org>; mgo...@gentoo.org <mgo...@gentoo.org>; 
mar...@martin.st <mar...@martin.st>; llvm-comm...@lists.llvm.org 
<llvm-comm...@lists.llvm.org>; h.imai....@nitech.jp <h.imai....@nitech.jp>; 
bhuvanendra.kum...@amd.com <bhuvanendra.kum...@amd.com>; gandhi21...@gmail.com 
<gandhi21...@gmail.com>; yanliang...@intel.com <yanliang...@intel.com>; 
liburd1...@outlook.com <liburd1...@outlook.com>; serhiy.re...@gmail.com 
<serhiy.re...@gmail.com>; quic_soura...@quicinc.com 
<quic_soura...@quicinc.com>; dougp...@gmail.com <dougp...@gmail.com>; 
david.spick...@linaro.org <david.spick...@linaro.org>; mlek...@skidmore.edu 
<mlek...@skidmore.edu>; blitzrak...@gmail.com <blitzrak...@gmail.com>; 
shen...@google.com <shen...@google.com>; michael.hl...@gmail.com 
<michael.hl...@gmail.com>; bruce.mitche...@gmail.com 
<bruce.mitche...@gmail.com>; yuanfang.c...@sony.com <yuanfang.c...@sony.com>
Subject: [EXTERNAL] [PATCH] D114639: Raise the minimum Visual Studio version to 
VS2019

RKSimon added a comment.

@stella.stamenova It looks like the mlir-windows buildbot is still using VS2017:

  CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message):
    Host Visual Studio version must be at least 19.20, your version is
    19.16.27045.0.

Are you able to make the fix or would you prefer I revert for now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD114639%2Fnew%2F&amp;data=04%7C01%7Cstilis%40microsoft.com%7C1299827a2cee41cb745b08d9e3184ba9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637790515814400729%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=WccQ1%2B3T0IE2c%2BrjkWNmZIFZFsQaaGq6NIM8gpduOpY%3D&amp;reserved=0

https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD114639&amp;data=04%7C01%7Cstilis%40microsoft.com%7C1299827a2cee41cb745b08d9e3184ba9%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637790515814400729%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=eymjF3kMlfwwx8%2Bf0B10dxYWaW%2BYkSuvmoWCCBuR2YE%3D&amp;reserved=0


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits