JDevlieghere added inline comments.
================
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864
+ for (const auto &subcommand_name : subcommands_found) {
+ auto qualified_name = (command_name + " " + subcommand_name).str();
+ commands_found.AppendString(std::move(qualified_name));
----------------
It's not obvious what type `qualified_name` is. I would either do:
```
std::string qualified_name = (command_name + " " +
subcommand_name).str();
```
or
```
auto qualified_name = std::string(command_name + " " + subcommand_name);
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116491/new/
https://reviews.llvm.org/D116491
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
