mgorny added a comment.

In D116005#3202721 <https://reviews.llvm.org/D116005#3202721>, @labath wrote:

> How about factoring the two implementations into subclasses. If the classes 
> are small, maybe you can just declare them in the cpp file...

Yes, that's a nice idea. As an extra, we can easily use the real pointer types 
and remove all these casts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116005/new/

https://reviews.llvm.org/D116005

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to