Ericson2314 added inline comments.

================
Comment at: lldb/cmake/modules/AddLLDB.cmake:1
+include(GNUInstallDirs)
 function(lldb_tablegen)
----------------
I think a problem with D115544 was that `AddLLVM` was assuming `GNUInstallDirs` 
yet downstream packages didn't yet include it.

By starting with "leaf" packages I side-step this issue somewhat, but I am 
still putting these here defensively so that downstream projects that might 
include these aren't broken, and the precedent is set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115570/new/

https://reviews.llvm.org/D115570

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to