mib marked 2 inline comments as done.
mib added inline comments.
================
Comment at: lldb/source/Target/StackFrame.cpp:1898
have_source = true;
- // TODO: Give here a one time warning if source file is missing.
+ if (!num_lines || !m_sc.line_entry.line ||
+ m_sc.line_entry.line == LLDB_INVALID_LINE_NUMBER) {
----------------
jingham wrote:
> I don't think it is correct to include `!num_lines` in this if. You get 0
> back from DIsplaySourceLines... if you found a good line table entry but the
> source file was not available. But that doesn't mean that this is artificial
> code.
>
> You also shouldn't remove the TO DO since you didn't do it.
Right (wrt to the condition).
I reverted the TODO and will take care of it in a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115313/new/
https://reviews.llvm.org/D115313
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
