teemperor added a comment.
I actually didn't see that the patch deleted the TestCppReferenceToOuterClass
test. Could you just add a `@skipIf # Crashes` or so above its `def test...`
method? The test itself is still valid user code that we shouldn't crash on.
I left some nits and the test source probably needs to be made a bit more
expressive in terms of what's its trying to test, but this can all be done
later. Let's just land this to get the regression fixed.
================
Comment at: lldb/test/API/commands/expression/pr52257/TestExprCrash.py:17
+ self.build()
+ self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
+ self.expect("expr b", substrs=["tag_set_ = nullptr"])
----------------
nit: `self.createTestTarget()` (which generates useful error messages on
failure)
================
Comment at: lldb/test/API/commands/expression/pr52257/TestExprCrash.py:18
+ self.dbg.CreateTarget(self.getBuildArtifact("a.out"))
+ self.expect("expr b", substrs=["tag_set_ = nullptr"])
----------------
nit: `self.expect_expr("b", result_type="B",
result_children=[ValueCheck(name="tag_set_")])`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113449/new/
https://reviews.llvm.org/D113449
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
